[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Patch: Strange problem in client tests fixed

From: Kevin Pilch-Bisson <kevin_at_pilch-bisson.net>
Date: 2001-01-25 21:05:14 CET

Hi all,

After nearly a full day of debugging, leading to liberal use of printfs
and eventually the fixing of APR and Neon's install targets so that I
could break out gdb, I determined that the behaviour was caused by
the return address of the call stack for
libsvn_wc/log.c:svn_run_cmd_in_directory before its call in
log_do_run_cmd. The result of this day of debugging is the following
whopper of a patch.

Modified: subversion/libsvn_wc/log.c
Log: Fixed size of args array.

Revision Changes Path
1.81 +1 -1 subversion/subversion/libsvn_wc/log.c

Index: log.c
===================================================================
RCS file: /cvs/subversion/subversion/libsvn_wc/log.c,v
retrieving revision 1.81
diff -u -p -r1.81 log.c
--- log.c 2001/01/23 18:43:21 1.81
+++ log.c 2001/01/25 19:58:56
@@ -324,7 +324,7 @@ log_do_run_cmd (struct log_runner *loggy
     *infile = NULL,
     *outfile = NULL,
     *errfile = NULL;
- const char *args[9];
+ const char *args[10];
   
   args[0] = name;
   /* Grab the arguments.

-- 
>~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Kevin Pilch-Bisson
kevin@pilch-bisson.net
http://www.pilch-bisson.net
PGP Public Key At http://pgp.pilch-bisson.net

  • application/pgp-signature attachment: stored
Received on Sat Oct 21 14:36:20 2006

This is an archived mail posted to the Subversion Dev mailing list.