[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: CVS update: subversion/subversion/include svn_io.h

From: Greg Stein <gstein_at_lyra.org>
Date: 2000-12-29 12:13:48 CET

On Fri, Dec 29, 2000 at 05:12:26AM -0500, Greg Hudson wrote:
> > I'd disagree. Passing NULL might be a bug. Calling the empty()
> > function explicitly will make it clearer that you intended to get an
> > empty stream.
>
> Well, I don't particularly object, but I found that it was more
> inconvenient (in terms of sheer verbiage) for the calling code than I
> had thought.

Your call. I'm not using it, but am just pointing out a potential gotcha.

> We could, of course, have svn_stream_from_possibly_null_aprfile(), but
> it's kind of hard to name such a monster reasonably.

hehe :-)

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/
Received on Sat Oct 21 14:36:18 2006

This is an archived mail posted to the Subversion Dev mailing list.