This isn't a complete review (I'm in the middle of something else
right now), just a couple of quick comments:
Branko =?ISO-8859-2?Q?=C8ibej?= <email@example.com> writes:
> It's actually two changes in SVN, but they're intermixed a bit, so I
> didn't try to pry them apart:
> * Change all tests of APR status codes (except for tests for
> APR_SUCCESS) to use APR_STATUS_IS_blabla() macros. This is
> necessary for Win32, because there are actually several different
> possible codes for some kinds of errors. The APR macros take care
> of that, and should be portable. This should also be the Right Way
> to write such tests in future.
Whoa, that's a really good idea. Thanks for pointing this out and
making the change; we should be careful to use this method from now
> * In check_adm_exist and svn_wc__ensure_directory, replace the
> apr_opendir checks with apr_stat. That's because apr_opendir won't
> return ENOENT on Win32, and I guess apr_stat should be faster in
> general, anyway. There might be a problem here with symlinks to
> directories, but from what I've seen, we don't support symlinks
> right now. Another possibility would be to change apr_opendir to
> return ENOENT everywhere.
Probably they should just use svn_io_check_path() now, actually; I'll
take a look and D.T.R.T.
Received on Sat Oct 21 14:36:14 2006