Re: CVS update: subversion/subversion/libsvn_delta xml_output.c

Greg Hudson <ghudson@MIT.EDU> writes:
> > (get_to_elem, apply_textdelta): use svn_xml_protect_pcdata when
> > creating text-deltas and prop-deltas.
>
> I think this change should be reverted.

Just my $0.02: I kind of think it would make more sense to leave it,
since that way we we don't have a bug lurking in wait for the day we
decide to change encoding schemes. True for prop-deltas too --
handling large and/or binary prop-deltas by putting them pcdata is
anticipated, so why not be prepared?

But definitely your call, as long as you know it's safe to revert it.
I won't argue, beyond the above paragraph. :-)

-K

> prop-delta elements do not contain meaningful pcdata, just set and
> delete elements.
>
> text-delta elements contain meaningful pcdata, but at the moment
> whitespace is irrelevant in there, since the data is base64-encoded.
> If we ever have other types of text-deltas, we might need to protect
> their pcdata, but we might not (e.g. the cosmetic newline is fine and
> good for gnudiff) and we'll need to make a bunch of other changes
> anyway.
Received on Sat Oct 21 14:36:12 2006