Re: CVS update: subversion/subversion/libsvn_delta delta_parse.c

On Sat, Aug 05, 2000 at 10:40:59PM -0000, Ben Sussman wrote:
>
> /* TODO: we're inside an event-driven callback. What do we
> do if we get an error? Just Punt? Call a warning
> callback? Perhaps we should have an error_handler()
> - inside our digger structure! */
> + inside our digger structure! Does Expat have a
> + mechanism, or do we need to longjump out? */
> }

FWIW (having written quite a lot of these "digger" thingies), I add an
'int valid' field to the "digger" structure, set it to 1 before
beginning the parse, and clear it if something goes bottoms up. Then
have
  if (!ctx->valid) return;
at the beginning of each callback.

joe
Received on Sat Oct 21 14:36:06 2006